Skip to content

Release ACS Rooms PSTN to GA#39437

Merged
mikehang-msft merged 11 commits intoAzure:mainfrom
allchiang-msft:allchiang-msft/rooms-pstn-GA
Apr 3, 2024
Merged

Release ACS Rooms PSTN to GA#39437
mikehang-msft merged 11 commits intoAzure:mainfrom
allchiang-msft:allchiang-msft/rooms-pstn-GA

Conversation

@allchiang-msft
Copy link
Member

@allchiang-msft allchiang-msft commented Mar 27, 2024

Description

PSTN feature was in BETA, now being released to GA
Swagger spec: Azure/azure-rest-api-specs#28124

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please add a period "." at the end of this line.

@allchiang-msft allchiang-msft force-pushed the allchiang-msft/rooms-pstn-GA branch from 2bf00ae to c62f4ad Compare April 1, 2024 18:09
### Bugs Fixed

### Other Changes
## 1.1.0 (2024-04-15)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the version in README too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme does not feature the latest version, would you point me to the area that should be updated?

Copy link
Member

@srnagar srnagar Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link above in my previous comment points to a section in README that has the version (it is outdated - 1.0.2). That should be updated to 1.1.0.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated and pushed, thanks

@mikehang-msft mikehang-msft merged commit a22c9eb into Azure:main Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants